Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scan Multiple AWS accounts via AssumeRole #172

Merged
merged 10 commits into from
Apr 7, 2021

Conversation

kmcquade
Copy link
Collaborator

@kmcquade kmcquade commented Mar 28, 2021

What does this PR do?

What gif best describes this PR or how it makes you feel?

image

Completion checklist

  • Additions and changes have unit tests
  • Python Unit tests, Pylint, security testing, and Integration tests are passing.
  • Javascript tests are passing (npm test)
  • If the UI contents or JavaScript files have been modified, generate a new example report (npm build and python3 ./utils/generate_example_report.py)
  • The pull request has been appropriately labeled using the provided PR labels

@kmcquade kmcquade added the DO-NOT-MERGE Don't merge yet label Mar 28, 2021
@kmcquade kmcquade self-assigned this Mar 28, 2021
@kmcquade kmcquade changed the title Feat/scan accounts command Scan Multiple AWS accounts via AssumeRole Mar 28, 2021
@kmcquade kmcquade removed the DO-NOT-MERGE Don't merge yet label Apr 6, 2021
@kmcquade
Copy link
Collaborator Author

kmcquade commented Apr 6, 2021

@yegorski - I went through and tested this out. Works great. We can also use the scan_account method to address #39 (Lambda support).

Let me know if it looks good to you. If so I will merge and we can release 0.4.0 :)

@kmcquade kmcquade added the enhancement New feature or request label Apr 6, 2021
@kmcquade
Copy link
Collaborator Author

kmcquade commented Apr 7, 2021

@yegorski - due to lots of demand, having tested this myself, and having addressed your previous suggestions I am going to go ahead and merge this PR and bump the version to 0.4.0.

I've updated the documentation to include instructions on scanning as well.

If you run into any issues, let me know. And feel free to open a new GitHub issue.

@kmcquade kmcquade merged commit af95f5e into salesforce:master Apr 7, 2021
@kmcquade kmcquade deleted the feat/scan-accounts-command branch April 7, 2021 15:48
@yegorski
Copy link

@kmcquade sounds great, thank you! Can't wait to use it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cross-account download functionality
2 participants