Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Add type hints to scan #203

Merged
merged 1 commit into from May 30, 2021
Merged

Conversation

gruebel
Copy link
Collaborator

@gruebel gruebel commented May 30, 2021

What does this PR do?

I added type hints to all Python methods in cloudsplaining.scan and also refactored some code parts, where possible. I changed the code pretty often to use list/dict comprehension, which is faster than just doing for loops.

What gif best describes this PR or how it makes you feel?

Completion checklist

  • Additions and changes have unit tests
  • The pull request has been appropriately labeled using the provided PR labels
  • GitHub actions automation is passing (make test, make lint, make security-test, make test-js)
  • If the UI contents or JavaScript files have been modified, generate a new example report:

@kmcquade
Copy link
Collaborator

Fantastic! Super helpful, thank you :)

@kmcquade kmcquade merged commit a615a4d into salesforce:master May 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants