Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug with returning final state in PackedLSTM? #9

Closed
sidbrahma opened this issue Jun 25, 2018 · 1 comment
Closed

Bug with returning final state in PackedLSTM? #9

sidbrahma opened this issue Jun 25, 2018 · 1 comment

Comments

@sidbrahma
Copy link

sidbrahma commented Jun 25, 2018 •
edited

decaNLP/models/common.py

Line 294 in 435cfcf

h, c = h[:, _indices, :], h[:, _indices, :]

While returning final states in PackedLSTM, the line reads
h, c = h[:, _indices, :], h[:, _indices, :]
It should be
h, c = h[:, _indices, :], c[:, _indices, :]
right?
@sidbrahma sidbrahma changed the title Bug with returning hidden and cell state in PackedLSTM? Bug with returning final state in PackedLSTM? Jun 25, 2018
@bmccann
Copy link
Contributor

bmccann commented Jun 26, 2018

Thanks! Should be fixed at 1c9f12b

@bmccann bmccann closed this as completed Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@bmccann @sidbrahma