Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification: missing assistive text #115

Closed
kaelig opened this issue Jan 12, 2016 · 3 comments
Closed

Notification: missing assistive text #115

kaelig opened this issue Jan 12, 2016 · 3 comments

Comments

@kaelig
Copy link
Contributor

kaelig commented Jan 12, 2016

In SLDS, notifications have an assistive text (before or after the close button).

See https://www.lightningdesignsystem.com/components/notifications
@donnieberg
Copy link
Contributor

Thanks, Kaelig! Is the assistive text always "info"? Or, what should it convey?

@kaelig
Copy link
Contributor Author

kaelig commented Jan 12, 2016

In the examples from SLDS, the assistive text was set as success, info or error.

It seems it should convey the type of content that is conveyed visually by the color and the icon.

@donnieberg
Copy link
Contributor

Fixed :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kaelig @donnieberg