Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site examples can only use components in index #1192

Closed
interactivellama opened this issue Dec 4, 2017 · 1 comment
Closed

Site examples can only use components in index #1192

interactivellama opened this issue Dec 4, 2017 · 1 comment
Labels
documentation

Comments

@interactivellama
Copy link
Contributor

interactivellama commented Dec 4, 2017 •
edited
Loading

No imports from example files, etc. Code mirror and the doc site only have access to the DSR components exported by components/index.js.

This should be mentioned in comments somewhere for contributors.
@interactivellama
Copy link
Contributor Author

interactivellama commented Dec 4, 2017 •
edited
Loading

@kevinlambert I'm updating your Progress Ring examples. The doc site examples can only be "the examples," unfortunately, they can't take an import from the examples folder. The ES6 imports are ignored/removed in the doc site examples and CodeMirror uses global access to the components exported by components/index.jsto run the doc site examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@interactivellama