Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hitting tab inside InlineEdit 'closes' input #702

Closed
iowillhoit opened this issue Oct 5, 2016 · 3 comments · Fixed by #1332
Closed

Hitting tab inside InlineEdit 'closes' input #702

iowillhoit opened this issue Oct 5, 2016 · 3 comments · Fixed by #1332

Comments

@iowillhoit
Copy link
Contributor

Seems to be an accessibility issue. You should be able to hit tab to focus on the (x) icon, and then hit space to actually 'close' the input.

2016-10-05 15 20 30

@interactivellama interactivellama added this to the Backlog milestone Nov 11, 2016
@interactivellama
Copy link
Contributor

@donnieberg I think this is a won't fix. What's a11y team take on this?

@donnieberg
Copy link
Contributor

@interactivellama actually, this is something that I'm changing in the Inline Edit component. The new behavior will be that when you're focused in the inline edit, you can tab to the "remove" icon, and then the next tab will blur the input. I posted about this change in the DSR slack channel and folks seems to be cool with the change.

@donnieberg
Copy link
Contributor

FYI @arodenbeck, I submitted a PR to change the behavior of Inline Edit so that you can Tab to the close button when in edit mode. When your focus is on the close button, pressing Tab again will blur the field now: #1332

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants