Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change inline edit for a11y, eslint updates #1332

Merged
merged 4 commits into from
May 1, 2018
Merged

Change inline edit for a11y, eslint updates #1332

merged 4 commits into from
May 1, 2018

Conversation

donnieberg
Copy link
Contributor

@donnieberg donnieberg commented Apr 20, 2018 •
edited by interactivellama
Loading

Old behavior was when you Tabbed from the input field, it'd skip over the close icon button inside and blur the input. New behavior is that it'll Tab to the close button, and if you're focused on the close button and Tab again, it'll blur the field.
Fixes #702

Additional description

Pull Request Review checklist (do not remove)

  • Review the appropriate Storybook stories. Open http://localhost:9001/.
  • Review tests are passing in the browser. Open http://localhost:8001/.
  • Review markup conforms to SLDS by looking at snapshot strings.
  • Add year-first date and commit SHA to last-slds-markup-review in package.json and push.
  • Request a review of the deployed Heroku app by the Salesforce UX Accessibility Team.
  • Add year-first review date, and commit SHA, last-accessibility-review, to package.json and push.
  • While the contributor's branch is checked out, run npm run local-update within locally cloned site repo to confirm the site will function correctly at the next release.

@donnieberg donnieberg mentioned this pull request Apr 20, 2018
Closed
@donnieberg
Change inline edit to be able to Tab from inline edit to 'x' button. …
4b54bb7 
…When 'x' is focused, Tab agin blurs the field
@interactivellama interactivellama added this to In progress in 2018-04b (April) Apr 25, 2018
@interactivellama
Merge branch 'master' of github.com:salesforce/design-system-react in…
477bbeb 
…to donnieberg-a11y-inlineEdit-fix
@interactivellama
Keep eslint config versions locked
4c67a47 
Style is somewhat arbitary as long as its consistent. `^` let’s it move around.
@interactivellama interactivellama changed the title Change inline edit for a11y Change inline edit for a11y, eslint updates May 1, 2018
@interactivellama interactivellama merged commit 854bde7 into salesforce:master May 1, 2018
2018-04b (April) automation moved this from In progress to Done May 1, 2018
interactivellama added a commit that referenced this pull request Jun 19, 2018
@interactivellama
Revert "Merge pull request #1332 from donnieberg/a11y-inlineEdit-fix"
17cf0f9 
Click to blur has not been accounted for and thus callbacks do not work correctly when using the mouse.

This reverts commit 854bde7, reversing
changes made to b7e2215.

# Conflicts:
#	package-lock.json
#	package.json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@interactivellama interactivellama interactivellama approved these changes

Assignees
No one assigned
Labels
cla:signed
Projects
No open projects
2018-04b (April)
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Hitting tab inside InlineEdit 'closes' input
2 participants
@donnieberg @interactivellama