feat: add no node env ssr rule #130

khangsfdc · 2023-10-11T19:00:10Z

lib/rules/no-node-env-in-ssr.js

Co-authored-by: Dale Bustad <dale@divmain.com>

test/lib/rules/no-node-env-ssr.js

divmain · 2023-10-11T22:02:14Z

Ping me in Slack when you've added the test cases, and I'll approve and merge.

divmain · 2023-10-12T23:57:20Z

This is fantastic, thanks Khang!

divmain and others added 5 commits August 3, 2023 14:32

chore: add rule to disallow process.env.NODE_ENV

6a9813e

docs: update no-node-env-in-ssr.md

e177015

chore: add no-node-env-in-ssr to README

bbb51f1

chore: prettier

f6a3ea8

test: add no-node-env-in-ssr

4240ac0

divmain requested changes Oct 11, 2023

View reviewed changes

lib/rules/no-node-env-in-ssr.js Outdated Show resolved Hide resolved

khangsfdc and others added 3 commits October 11, 2023 15:42

Update lib/rules/no-node-env-in-ssr.js

48f4d22

Co-authored-by: Dale Bustad <dale@divmain.com>

fix: add rule-helper for no-node-env

1ce2533

fix: add object guard

1da2e07

kevinv11n reviewed Oct 11, 2023

View reviewed changes

test/lib/rules/no-node-env-ssr.js Show resolved Hide resolved

khangsfdc added 2 commits October 12, 2023 13:36

test: add more tests

9dcdbcb

fix: typo

352f942

divmain approved these changes Oct 12, 2023

View reviewed changes

divmain merged commit c5ef560 into salesforce:master Oct 12, 2023
6 checks passed

Provide feedback