@W-13102797 [M6 Automation LOB] Enable ^ Power operator for offline … #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…upport @W-13102797 [M6 Automation LOB] Enable ^ Power operator for offline support
|
Thanks for the contribution! It looks like @aditya-jain3 is an internal user so signing the CLA is not required. However, we need to confirm this. |
| @@ -15,7 +15,8 @@ | |||
| * @author djacobs | |||
| * @since 140 | |||
| */ | |||
| @AllowedContext(section = SelectorSection.MATH) // Not supported in offline because of the precision loss. | |||
| @AllowedContext(section = SelectorSection.MATH,isOffline=true) | |||
| // We are enabling support for offline. But in case of High precision, result might be different than the result from SQL. | |||
There was a problem hiding this comment.
We should add tests to sure this function works offline. Also we should add concrete tests between SQL vs offline with high precision enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@W-13102797
[M6 Automation LOB] Enable ^ Power operator for offline support