@W-14781712 fix: added null checks #143
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the contribution! It looks like @abbasmanthirik is an internal user so signing the CLA is not required. However, we need to confirm this. |
sahil-here
requested changes
Apr 1, 2024
There was a problem hiding this comment.
We have a few queries:
Code Change related:
- Why a null check has been added here for W-14781712 where EntityFormulaContextBase.createMockFieldInfo is throwing the "IllegalArgumentException: entity Info is null"? How is this check related to that exception?
Code Quality related: - Why there is a need for the "else" block?
- Why the same check has not been added to the another constructor of the same class?
- Why has the datatype been updated from primitive to object for location and type? If yes, then does the getter/setter need to be updated or not, has that been considered?
`
|
sahil-here
reviewed
May 6, 2024
| @@ -64,8 +70,13 @@ public WrongArgumentTypeException(String function, Type[] expectedInputTypes, Fo | |||
|
|
|||
| Token token = actual.getToken(); | |||
| location = token.getColumn(); | |||
There was a problem hiding this comment.
Why is the "location" outside the null check here?
There was a problem hiding this comment.
Was a miss. Fixed it. Thanks
There was a problem hiding this comment.
Why is the "location" outside the null check here?
Done
sahil-here
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added null checks for token