@W-15644208 Upgrade formula-engine to Java/Jakarta EE 9 namespace #146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bairenlong-sfdc
commented
Jun 6, 2024
| @@ -22,8 +22,8 @@ | |||
| <artifactId>grammaticus</artifactId> | |||
| </dependency> | |||
| <dependency> | |||
| <groupId>javax.annotation</groupId> | |||
There was a problem hiding this comment.
using jarkatar annotation package
bairenlong-sfdc
commented
Jun 6, 2024
| import com.force.formula.FormulaFieldReference; | ||
| import com.google.errorprone.annotations.Immutable; |
There was a problem hiding this comment.
use Immutable from google, the rest changes are from IDE reformatting
bairenlong-sfdc
commented
Jun 6, 2024
| import com.force.i18n.commons.text.DeferredStringBuilder; | ||
| import com.force.i18n.commons.util.collection.IntHashMap; | ||
| import com.google.common.base.CharMatcher; | ||
| import com.google.common.base.Joiner; | ||
| import com.google.common.escape.Escaper; | ||
| import com.google.common.escape.Escapers; | ||
| import com.google.errorprone.annotations.Immutable; | ||
|
|
||
| import jakarta.annotation.Nullable; |
There was a problem hiding this comment.
using packages from jakarta & google, the rest are from IDE reformatting
bairenlong-sfdc
commented
Jun 6, 2024
| @@ -379,6 +382,29 @@ | |||
| </execution> | |||
| </executions> | |||
| </plugin> | |||
|
|
|||
| <!-- temp to fix eclipse compiler error--> | |||
There was a problem hiding this comment.
This is for eclipse on local only.
bairenlong-sfdc
commented
Jun 6, 2024
| <dependency> | ||
| <groupId>org.testcontainers</groupId> | ||
| <artifactId>gcloud</artifactId> | ||
| <version>${testcontainers.version}</version> | ||
| <optional>true</optional> | ||
| </dependency> | ||
| <dependency> |
There was a problem hiding this comment.
moved to google-test to make test-utils EE9 ready
jfreschl
approved these changes
Jun 6, 2024
bairenlong-sfdc
commented
Jun 6, 2024
api/pom.xml
Outdated
| @@ -9,7 +9,7 @@ | |||
| <parent> | |||
| <groupId>com.salesforce.formula</groupId> | |||
| <artifactId>formula-engine</artifactId> | |||
| <version>0.3.23-SNAPSHOT</version> | |||
| <version>0.9.0-SNAPSHOT</version> | |||
There was a problem hiding this comment.
We will starting with version 3.9.0 for EE9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed with @jfreschl, we will merge this to main to make it easier to fix other bugs.
We will release from this branch (main-jakarta) to core/252, we will merge this to main after all is good with ee9