Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing functions to Input LWC #22

Merged
merged 3 commits into from
Feb 15, 2019

Conversation

mattgoldspink
Copy link
Contributor

Should fix #21

@salesforce-cla
Copy link

Thanks for the contribution! Unfortunately we can't verify the commit author(s): Matt Goldspink <m***@v***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, sign the Salesforce.com Contributor License Agreement and this Pull Request will be revalidated.

Copy link
Contributor

@trevor-bliss trevor-bliss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the missing methods! I'd like the validity prop to remain without the default value though.

src/lightning-mocks/input/input.js Outdated Show resolved Hide resolved
@trevor-bliss trevor-bliss merged commit 20a5044 into salesforce:master Feb 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightning input mock is missing some methods
2 participants