fix: update dynamic import terminology #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gordotango
approved these changes
Feb 1, 2021
pmdartus
reviewed
Feb 2, 2021
| @@ -331,7 +337,7 @@ The compiler add to its metadata all of the parsed dynamic imports, its source v | |||
|
|
|||
| ## Drawbacks | |||
|
|
|||
| The biggest drawback of this feature is the historic abuse of dynamic component creation in the Lightning Platform. We will add guardrails to prevent developers from shooting themselves in the foot. | |||
| The biggest drawback of this feature is the historic abuse of dynamic imports in the Lightning Platform. We will add guardrails to prevent developers from shooting themselves in the foot. | |||
There was a problem hiding this comment.
This is also the case of dynamic component instantiation. Some developers are using this approach while branching in the template (using if:true, if:false) is preferable.
Co-authored-by: Pierre-Marie Dartus <dartus.pierremarie@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.