chore: release v2.23.3 @W-11731809 (#3040)

* build: replace lerna with nx (#2965) * fix(template-compiler): add deprecated void elements back (#3037) * chore: release v2.23.3 (#3039)
salesforce · Sep 10, 2022 · 255fffa · 255fffa
1 parent c8d2076
commit 255fffa
Show file tree

Hide file tree

Showing 46 changed files with 1,064 additions and 331 deletions.
diff --git a/.circleci/config.yml b/.circleci/config.yml
@@ -92,6 +92,21 @@ commands:
           paths:
             - ~/.cache/yarn
 
+  restore_nx_cache:
+    description: Restore nx cache from previous build
+    steps:
+      - restore_cache:
+          keys:
+            - nx-v3-{{ checksum "yarn.lock" }}
+
+  save_nx_cache:
+    description: Save nx cache for future builds
+    steps:
+      - save_cache:
+          key: nx-v3-{{ checksum "yarn.lock" }}
+          paths:
+            - ~/lwc/.nx-cache
+
   save_workspace:
     description: Save current workspace
     steps:
@@ -170,6 +185,7 @@ jobs:
     steps:
       - checkout
       - restore_yarn_cache
+      - restore_nx_cache
       - run:
           name: Install dependencies and build
           command: yarn install --frozen-lockfile
@@ -186,6 +202,7 @@ jobs:
           name: Check the size of the LWC bundle
           command: yarn bundlesize
       - save_yarn_cache
+      - save_nx_cache
       - save_workspace
 
 

diff --git a/.gitignore b/.gitignore
@@ -7,6 +7,7 @@ node_modules/
 coverage/
 .idea/
 .project/
+.nx-cache
 
 lib/
 playground/dist/

diff --git a/.nucleus.yaml b/.nucleus.yaml
@@ -72,3 +72,11 @@ steps:
   npm-configure-for-publish:
     params:
       registry-url: https://registry.npmjs.org
+  node-save-dep-cache: &node-save-dep-cache
+    params:
+      paths:
+        # it's necessary to redeclare **/node_modules because this overrides the default behavior
+        - '**/node_modules'
+        # add NX cache
+        - '.nx-cache'
+    after: node-build
diff --git a/lerna.json b/lerna.json
diff --git a/nx.json b/nx.json
@@ -0,0 +1,31 @@
+{
+    "extends": "nx/presets/npm.json",
+    "tasksRunnerOptions": {
+        "default": {
+            "runner": "nx/tasks-runners/default",
+            "options": {
+                "cacheDirectory": "./.nx-cache",
+                "cacheableOperations": ["build", "dev"]
+            }
+        }
+    },
+    "targetDefaults": {
+        "build": {
+            "dependsOn": ["^build"]
+        },
+        "dev": {
+            "dependsOn": ["^build"]
+        },
+        "//": "Build @lwc/perf-benchmarks dependencies and build target when invoking the test:performance script on the root package.json.",
+        "test": {
+            "dependsOn": ["build"]
+        },
+        "//": "Build @lwc/integration dependencies when invoking the test:integration script on the root package.json.",
+        "sauce": {
+            "dependsOn": ["^build"]
+        }
+    },
+    "affected": {
+        "defaultBase": "master"
+    }
+}
diff --git a/package.json b/package.json
@@ -1,92 +1,92 @@
 {
-  "name": "lwc-monorepo",
-  "private": true,
-  "description": "Lightning Web Components",
-  "repository": {
-    "type": "git",
-    "url": "https://github.com/salesforce/lwc.git"
-  },
-  "scripts": {
-    "prepare": "husky install && yarn build",
-    "clean": "lerna run clean && lerna clean --yes && rm -rf node_modules",
-    "lint": "eslint packages/ scripts/ --ext=js,mjs,ts",
-    "format": "prettier --write '{packages,scripts}/**/*.{js,mjs,ts,json,md}'",
-    "bundlesize": "bundlesize --config ./scripts/bundlesize/bundlesize.config.json",
-    "build": "lerna run build --ignore @lwc/perf-benchmarks --ignore @lwc/perf-benchmarks-components --ignore @lwc/integration-tests",
-    "build:performance": "yarn run build:performance:components && yarn run build:performance:benchmarks",
-    "build:performance:components": "lerna exec --scope @lwc/perf-benchmarks-components -- yarn build",
-    "build:performance:benchmarks": "lerna exec --scope @lwc/perf-benchmarks -- yarn build",
-    "dev": "lerna run dev --parallel --ignore @lwc/perf-benchmarks --ignore @lwc/perf-benchmarks-components --ignore @lwc/integration-tests",
-    "test": "jest --config ./scripts/jest/root.config.js",
-    "test:debug": "node --inspect node_modules/.bin/jest --config ./scripts/jest/root.config.js --runInBand --watch",
-    "test:ci": "yarn test --no-cache --coverage --runInBand",
-    "test:integration": "lerna exec --scope @lwc/integration-tests -- yarn sauce",
-    "test:performance": "lerna exec --scope @lwc/perf-benchmarks -- yarn test",
-    "release:publish:ci": "./scripts/release/publish.mjs",
-    "release:version": "./scripts/release/version.mjs"
-  },
-  "devDependencies": {
-    "@babel/core": "^7.18.13",
-    "@babel/preset-env": "^7.18.10",
-    "@commitlint/cli": "^17.1.2",
-    "@lwc/eslint-plugin-lwc-internal": "link:./scripts/eslint-plugin",
-    "@lwc/jest-utils-lwc-internals": "link:./scripts/jest/utils",
-    "@rollup/plugin-node-resolve": "^13.3.0",
-    "@rollup/plugin-replace": "^4.0.0",
-    "@rollup/plugin-typescript": "^8.4.0",
-    "@types/babel__core": "^7.1.19",
-    "@types/glob": "^7.2.0",
-    "@types/jest": "^28.1.8",
-    "@types/node": "^18.7.13",
-    "@typescript-eslint/eslint-plugin": "^5.35.1",
-    "@typescript-eslint/parser": "^5.35.1",
-    "babel-plugin-tester": "^10.1.0",
-    "bundlesize": "^0.18.1",
-    "es5-proxy-compat": "^0.22.4",
-    "eslint": "^8.23.0",
-    "eslint-plugin-import": "^2.26.0",
-    "eslint-plugin-jest": "^27.0.1",
-    "execa": "^6.1.0",
-    "fs-extra": "^10.1.0",
-    "glob": "^8.0.3",
-    "husky": "^8.0.1",
-    "is-ci": "^3.0.1",
-    "isbinaryfile": "^5.0.0",
-    "jest": "^28.1.3",
-    "jest-environment-jsdom": "^28.1.3",
-    "lerna": "^5.4.3",
-    "lint-staged": "^13.0.3",
-    "prettier": "^2.7.1",
-    "rollup": "^2.78.1",
-    "rollup-plugin-compat": "^0.22.4",
-    "terser": "^5.15.0",
-    "ts-jest": "^28.0.8",
-    "tslib": "^2.4.0",
-    "typescript": "4.7.4",
-    "workerpool": "^6.2.0"
-  },
-  "lint-staged": {
-    "**/*.{js,mjs,ts}": "eslint",
-    "{packages,scripts}/**/*.{js,mjs,ts,json,md}": "prettier --write"
-  },
-  "workspaces": [
-    "packages/@lwc/*",
-    "packages/lwc",
-    "playground"
-  ],
-  "engines": {
-    "node": ">=10"
-  },
-  "volta": {
-    "node": "16.15.1",
-    "yarn": "1.22.19"
-  },
-  "resolutions": {
-    "//": [
-      "jasmine-core: Freezing jasmine version used in Karma test suite. jasmine-core@4 drops support for IE11.",
-      "iltorb: Native module used by bundlesize which slows down yarn install and may fail on some envs. Not needed."
+    "name": "lwc-monorepo",
+    "version": "2.23.3",
+    "private": true,
+    "description": "Lightning Web Components",
+    "repository": {
+        "type": "git",
+        "url": "https://github.com/salesforce/lwc.git"
+    },
+    "scripts": {
+        "prepare": "husky install && yarn build",
+        "lint": "eslint packages/ scripts/ --ext=js,mjs,ts",
+        "format": "prettier --write '{packages,scripts}/**/*.{js,mjs,ts,json,md}'",
+        "bundlesize": "bundlesize --config ./scripts/bundlesize/bundlesize.config.json",
+        "build": "nx run-many --target=build --all --exclude=@lwc/perf-benchmarks,@lwc/perf-benchmarks-components,@lwc/integration-tests",
+        "build:performance": "yarn build:performance:components && yarn build:performance:benchmarks",
+        "build:performance:components": "nx build @lwc/perf-benchmarks-components",
+        "build:performance:benchmarks": "nx build @lwc/perf-benchmarks",
+        "dev": "nx run-many --target=dev --all --parallel=999 --exclude=@lwc/perf-benchmarks,@lwc/perf-benchmarks-components,@lwc/integration-tests",
+        "test": "jest --config ./scripts/jest/root.config.js",
+        "test:debug": "node --inspect node_modules/.bin/jest --config ./scripts/jest/root.config.js --runInBand --watch",
+        "test:ci": "yarn test --no-cache --coverage --runInBand",
+        "test:integration": "nx sauce @lwc/integration-tests",
+        "test:performance": "nx test @lwc/perf-benchmarks",
+        "release:version": "./scripts/release/version.js"
+    },
+    "devDependencies": {
+        "@babel/core": "^7.18.13",
+        "@babel/preset-env": "^7.18.10",
+        "@commitlint/cli": "^17.1.2",
+        "@lwc/eslint-plugin-lwc-internal": "link:./scripts/eslint-plugin",
+        "@lwc/jest-utils-lwc-internals": "link:./scripts/jest/utils",
+        "@rollup/plugin-node-resolve": "^13.3.0",
+        "@rollup/plugin-replace": "^4.0.0",
+        "@rollup/plugin-typescript": "^8.4.0",
+        "@types/babel__core": "^7.1.19",
+        "@types/glob": "^7.2.0",
+        "@types/jest": "^28.1.8",
+        "@types/node": "^18.7.13",
+        "@typescript-eslint/eslint-plugin": "^5.35.1",
+        "@typescript-eslint/parser": "^5.35.1",
+        "babel-plugin-tester": "^10.1.0",
+        "bundlesize": "^0.18.1",
+        "es5-proxy-compat": "^0.22.4",
+        "eslint": "^8.23.0",
+        "eslint-plugin-import": "^2.26.0",
+        "eslint-plugin-jest": "^27.0.1",
+        "execa": "^6.1.0",
+        "fs-extra": "^10.1.0",
+        "glob": "^8.0.3",
+        "husky": "^8.0.1",
+        "is-ci": "^3.0.1",
+        "isbinaryfile": "^5.0.0",
+        "jest": "^28.1.3",
+        "jest-environment-jsdom": "^28.1.3",
+        "lerna": "^5.4.3",
+        "lint-staged": "^13.0.3",
+        "nx": "14.4.3",
+        "prettier": "^2.7.1",
+        "rollup": "^2.78.1",
+        "rollup-plugin-compat": "^0.22.4",
+        "terser": "^5.15.0",
+        "ts-jest": "^28.0.8",
+        "tslib": "^2.4.0",
+        "typescript": "4.7.4",
+        "workerpool": "^6.2.0"
+    },
+    "lint-staged": {
+        "**/*.{js,mjs,ts}": "eslint",
+        "{packages,scripts}/**/*.{js,mjs,ts,json,md}": "prettier --write"
+    },
+    "workspaces": [
+        "packages/@lwc/*",
+        "packages/lwc",
+        "playground"
     ],
-    "jasmine-core": "3.10.1",
-    "iltorb": "npm:@stdlib/utils-noop@0.0.10"
-  }
+    "engines": {
+        "node": ">=10"
+    },
+    "volta": {
+        "node": "16.15.1",
+        "yarn": "1.22.19"
+    },
+    "resolutions": {
+        "//": [
+            "jasmine-core: Freezing jasmine version used in Karma test suite. jasmine-core@4 drops support for IE11.",
+            "iltorb: Native module used by bundlesize which slows down yarn install and may fail on some envs. Not needed."
+        ],
+        "jasmine-core": "3.10.1",
+        "iltorb": "npm:@stdlib/utils-noop@0.0.10"
+    }
 }
diff --git a/packages/@lwc/aria-reflection-polyfill/package.json b/packages/@lwc/aria-reflection-polyfill/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@lwc/aria-reflection-polyfill",
-    "version": "2.23.2",
+    "version": "2.23.3",
     "description": "ARIA element reflection polyfill for strings",
     "homepage": "https://lwc.dev/",
     "repository": {
@@ -16,7 +16,6 @@
     "license": "MIT",
     "typings": "types/index.d.ts",
     "scripts": {
-        "clean": "rm -rf dist/ types/",
         "build": "rollup --config scripts/rollup.config.js",
         "dev": "rollup  --config scripts/rollup.config.js --watch --no-watch.clearScreen"
     },
@@ -35,6 +34,16 @@
         "access": "public"
     },
     "dependencies": {
-        "@lwc/shared": "2.23.2"
+        "@lwc/shared": "2.23.3"
+    },
+    "nx": {
+        "targets": {
+            "build": {
+                "outputs": [
+                    "./dist",
+                    "./types"
+                ]
+            }
+        }
     }
 }
diff --git a/packages/@lwc/babel-plugin-component/package.json b/packages/@lwc/babel-plugin-component/package.json
@@ -10,7 +10,7 @@
     "bugs": {
         "url": "https://github.com/salesforce/lwc/issues"
     },
-    "version": "2.23.2",
+    "version": "2.23.3",
     "main": "src/index.js",
     "typings": "src/index.d.ts",
     "license": "MIT",
@@ -21,8 +21,8 @@
     ],
     "dependencies": {
         "@babel/helper-module-imports": "~7.18.6",
-        "@lwc/errors": "2.23.2",
-        "@lwc/shared": "2.23.2",
+        "@lwc/errors": "2.23.3",
+        "@lwc/shared": "2.23.3",
         "line-column": "~1.0.2"
     },
     "peerDependencies": {

diff --git a/packages/@lwc/compiler/package.json b/packages/@lwc/compiler/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@lwc/compiler",
-    "version": "2.23.2",
+    "version": "2.23.3",
     "description": "LWC compiler",
     "homepage": "https://lwc.dev/",
     "repository": {
@@ -15,7 +15,6 @@
     "typings": "dist/types/index.d.ts",
     "license": "MIT",
     "scripts": {
-        "clean": "rm -rf dist/",
         "build": "tsc && node ./scripts/update-compiler-version.js",
         "dev": "tsc --watch --preserveWatchOutput  --incremental"
     },
@@ -26,13 +25,22 @@
         "@babel/core": "~7.18.13",
         "@babel/plugin-proposal-class-properties": "~7.18.6",
         "@babel/plugin-proposal-object-rest-spread": "~7.18.9",
-        "@lwc/babel-plugin-component": "2.23.2",
-        "@lwc/errors": "2.23.2",
-        "@lwc/shared": "2.23.2",
-        "@lwc/style-compiler": "2.23.2",
-        "@lwc/template-compiler": "2.23.2"
+        "@lwc/babel-plugin-component": "2.23.3",
+        "@lwc/errors": "2.23.3",
+        "@lwc/shared": "2.23.3",
+        "@lwc/style-compiler": "2.23.3",
+        "@lwc/template-compiler": "2.23.3"
     },
     "publishConfig": {
         "access": "public"
+    },
+    "nx": {
+        "targets": {
+            "build": {
+                "outputs": [
+                    "./dist"
+                ]
+            }
+        }
     }
 }