Skip to content

Commit

Permalink
address feedbacks
Browse files Browse the repository at this point in the history
  • Loading branch information
yungcheng committed Jan 24, 2018
1 parent bc81831 commit 4a44111
Show file tree
Hide file tree
Showing 7 changed files with 11 additions and 19 deletions.
10 changes: 5 additions & 5 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ Please check if your PR fulfills the following requirements:

Supported commit types: build, chore, ci, docs, feat, fix, perf, refactor, revert, style, test.
Supported scope: The scope should be the name of the npm package affected (engine, compiler, wire-service, etc.)
- More details on LWC semantic commit can be found [here](https://github.com/salesforce/lwc/blob/master/CONTRIBUTING.md#commit).


- More details on LWC semantic commit can be found [here](CONTRIBUTING.md#commit).



#### Other information:

10 changes: 3 additions & 7 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,7 @@ Please familiarize yourself with the [project philosophy][project-philosophy].
git clone git@github.com:salesforce/lwc.git
```

### 2) Setup npm/yarn to use Nexus repositories

Nexus provides a public caching proxy and a private repository which hosts several dependent lwc modules. Follow the instructions at [https://sfdc.co/npm-nexus](https://sfdc.co/npm-nexus) to setup access to the Nexus npm registry.

### 3) Install Dependencies
### 2) Install Dependencies

*We use [yarn](https://yarnpkg.com/) because it is significantly faster than npm for our use case. See this command [cheatsheet](https://yarnpkg.com/lang/en/docs/migrating-from-npm/).*

Expand All @@ -32,13 +28,13 @@ yarn install

If this fails with an error about *UNABLE_TO_GET_ISSUER_CERT_LOCALLY*, *Error: unable to get local issuer certificate*, or a registry communication issue then re-verify that step 2 was successful.

### 4) Start the server
### 3) Start the server

```bash
yarn start
```

### 5) View examples
### 4) View examples

Load the examples in a browser: [http://localhost:8080/](http://localhost:8080/)

Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# LWC Repository

This repository contains the source code for the LWC Engine and Compiler. Additionaly, it contains examples, documentation, meeting notes and discussion notes for developers [contributing](https://github.com/salesforce/lwc/blob/master/CONTRIBUTING.md) or using Raptor.
This repository contains the source code for the LWC Engine and Compiler. Additionaly, it contains examples, documentation, meeting notes and discussion notes for developers [contributing](CONTRIBUTING.md) or using Raptor.

## Getting Start

Expand All @@ -12,7 +12,7 @@ This project is been developed by the Raptor Team in collaboration with Aura Tea

## Contributing

Read our [contributing documentation](https://github.com/salesforce/lwc/blob/master/CONTRIBUTING.md) to set up your environment and start contributing.
Read our [contributing documentation](CONTRIBUTING.md) to set up your environment and start contributing.

## License

Expand Down
1 change: 0 additions & 1 deletion packages/lwc-engine/src/framework/patch.ts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ export const patch = init([
// Attrs need to be applied to element before props
// IE11 will wipe out value on radio inputs if value
// is set before type=radio.
// See lwc(internal) #791 for more
attrs,
props,
classes,
Expand Down
2 changes: 1 addition & 1 deletion packages/lwc-integration/src/shared/test-case.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ export default class TestCase extends Element {
}
get issueHref() {
return `https://git.soma.salesforce.com/raptor/raptor/issues/${this.issueId}`;
return `https://github.com/salesforce/lwc/issues/${this.issueId}`;
}
get headerStyle() {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
<template>
<!-- Regression: https://git.soma.salesforce.com/raptor/raptor/issues/627 -->
<slot name="secret-slot">
<p>Test slot content</p>
</slot>
Expand Down
2 changes: 0 additions & 2 deletions packages/proxy-compat/src/__tests__/object-test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ describe('ECMA Object', function () {
// We do not patch Object.getOwnPropertySymbols because
// it is patched by the Symbol polyfill later on
// in the code. As a result, this test will not work in node.
// See lwc(internal) #833
xit('should return correct keys from proxy', function () {
const proxy = new XProxy({
foo: 'bar'
Expand All @@ -35,7 +34,6 @@ describe('ECMA Object', function () {
// We do not patch Object.getOwnPropertySymbols because
// it is patched by the Symbol polyfill later on
// in the code. As a result, this test will not work in node.
// See lwc(internal) #833
xit('should assign symbols correctly', function () {
const sym = Symbol();
const proxy = new XProxy({ foo: 'bar', [sym]: 1 }, {});
Expand Down

0 comments on commit 4a44111

Please sign in to comment.