Skip to content

Commit

Permalink
fix(engine): define setter along with getter in global html attr (#277)
Browse files Browse the repository at this point in the history
* fix(engine): define setter along with getter in global html attr

* wip: fix lint, update comment

* wip: dummy commit to re-run Best
  • Loading branch information
Trevor committed May 8, 2018
1 parent 888bd0d commit 5324101
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion packages/lwc-engine/src/framework/html-element.ts
Original file line number Diff line number Diff line change
Expand Up @@ -346,10 +346,11 @@ if (process.env.NODE_ENV !== 'production') {
console.log(msg.join('\n')); // tslint:disable-line
return; // explicit undefined
},
// a setter is required here to avoid TypeError's when an attribute is set in a template but only the above getter is defined
set() {}, // tslint:disable-line
enumerable: false,
});
});

}

freeze(LWCElement);
Expand Down

0 comments on commit 5324101

Please sign in to comment.