chore: address review feedback

salesforce · Apr 16, 2024 · 85f8a18 · 85f8a18
1 parent a2b8f7a
commit 85f8a18
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 11 deletions.
diff --git a/packages/@lwc/template-compiler/src/__tests__/index.spec.ts b/packages/@lwc/template-compiler/src/__tests__/index.spec.ts
@@ -48,7 +48,7 @@ describe('parse', () => {
         ];
         configs.forEach(({ name, config }) => {
             it(`parse() with double </template> with config=${name}`, () => {
-                const result = parse('<template></template></template>', '', config);
+                const result = parse('<template></template></template>', config);
                 const expectWarning = config.apiVersion === 58; // null/undefined/unspecified is treated as latest
                 expect(result.warnings.length).toBe(1);
                 expect(result.warnings[0].level).toBe(

diff --git a/packages/@lwc/template-compiler/src/config.ts b/packages/@lwc/template-compiler/src/config.ts
@@ -91,9 +91,9 @@ export interface Config {
      */
     apiVersion?: number;
 }
-type OptionalConfigValues = 'customRendererConfig' | 'instrumentation' | 'namespace' | 'name';
-type RequiredConfigOptions = Required<Omit<Config, OptionalConfigValues>>;
-type OptionalConfigOptions = Partial<Pick<Config, OptionalConfigValues>>;
+type OptionalConfigNames = 'customRendererConfig' | 'instrumentation' | 'namespace' | 'name';
+type RequiredConfigOptions = Required<Omit<Config, OptionalConfigNames>>;
+type OptionalConfigOptions = Partial<Pick<Config, OptionalConfigNames>>;
 export type NormalizedConfig = RequiredConfigOptions & OptionalConfigOptions;
 
 const AVAILABLE_OPTION_NAMES = new Set([

diff --git a/packages/@lwc/template-compiler/src/index.ts b/packages/@lwc/template-compiler/src/index.ts
@@ -26,17 +26,13 @@ export { Config } from './config';
 /**
  * Parses HTML markup into an AST
  * @param source HTML markup to parse
- * @param filename HTML filename
  * @param config HTML template compilation config
  * @returns Object containing the AST
  */
-export function parse(
-    source: string,
-    filename: string = '',
-    config: Config = {}
-): TemplateParseResult {
+export function parse(source: string, config: Config = {}): TemplateParseResult {
     const options = normalizeConfig(config);
-    const state = new State(options, filename);
+    // The file name is never used in this function, defaulting it to an empty string.
+    const state = new State(options, '');
     return parseTemplate(source, state);
 }
 
@@ -56,6 +52,8 @@ export default function compile(
     config: Config
 ): TemplateCompileResult {
     const options = normalizeConfig(config);
+    // Note the file name is required to generate implicit css imports and style tokens.
+    // It is not part of the config because all values in the config are optional by convention.
     const state = new State(options, filename);
 
     let code = '';