fix(babel-plugin-component): correct class member decorator validation #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apapko
changed the title
Benchmark resultsBase commit: lwc-engine-benchmark
|
pmdartus
approved these changes
Mar 20, 2019
| @@ -145,6 +149,7 @@ module.exports = function validate(klass, decorators) { | |||
| } | |||
| }); | |||
|
|
|||
| //console.log('---> decorators: ', decorators); | |||
There was a problem hiding this comment.
Suggested change
| //console.log('---> decorators: ', decorators); |
ekashida
reviewed
Mar 20, 2019
| const parentPath = path.parentPath; | ||
| const name = parentPath.get('key.name').node; | ||
|
|
||
| const associatedGetter = decorators.find( |
There was a problem hiding this comment.
Could you explain how this find operation was picking up class methods that were not decorated with @api?
There was a problem hiding this comment.
it was not. The filter logic resulted in a list of @api decorated setters and the find function was only looking at @api decorated getters. The issue was that we weren't cross referencing setter method name with the getter method name ( line 94 didn't check the current getter method name ).
Benchmark resultsBase commit: lwc-engine-benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #1113 - improve decorator validation logic.
Does this PR introduce a breaking change?