wire adapter typescript def is incorrect

[kevinv11n]

Description

In https://github.com/salesforce/lwc/blob/master/packages/lwc-engine/types/engine.d.ts#L75 we define wire like this:

export function wire(adapterId: string, adapterConfig: Object): void;

This is not correct. It needs to be defined as a property and method decorator.

As a comparison, see how track is defined:

export const track: PropertyDecorator;

Steps to Reproduce

1. Open the mono repo in VS Code
2. Open single-wire.js

[kevinv11n]

@caridy You mentioned there were other gaps in engine.d.ts. Can we merge this with that issue or repurpose this to cover it all?

[caridy]

The idea is to eliminate engine.d.ts as a manual file, and produce one as part of the build process. @rsalvador and I decided to keep this around because it was easier, but right after the next cut, we should remove that.

The concern is mostly that a generated file will contain everything, while devs will only have access to some things, other are meant to be used for other tools (e.g.: Aura), and we haven't found an easy way to have that split in the types as well.

[rsalvador]

For the lwc-language-service we will also need an updated engine.d.ts for 214

[rsalvador]

Here I was adding a missing method: #60
After that I did look a little into how to generate the engine.d.ts automatically but it did look pretty complicated to generate the equivalent of engine.d.ts

[caridy]

Is this still an issue @rsalvador @kevinv11n ?

[rsalvador]

We can close this, the wire def was updated here: a091304

[kevinv11n]

Config bag needs to be optional. I'll issue a PR shortly.