Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update broken links #22

Closed
pmdartus opened this issue Jan 22, 2018 · 11 comments
Closed

Update broken links #22

pmdartus opened this issue Jan 22, 2018 · 11 comments

Comments

@pmdartus
Copy link
Member

Description

With the migration to github some links, some links in the repo are now broken. Here is list of all the files containing references to git.soma:

$ ag soma.salesforce -l
CHANGELOG.md
docs/proposals/error-code-system-2-mimic-assembly-script.md
docs/proposals/structured-commits.md
README.md
package.json
CONTRIBUTING.md
packages/benchmark/README.md
packages/proxy-compat/src/__tests__/object-test.ts
packages/lwc-engine/dist/umd/es5/engine.js
packages/lwc-engine/dist/umd/es2017/engine_debug.js
packages/lwc-engine/dist/commonjs/es5/engine.js
packages/lwc-engine/dist/umd/es5/engine_debug.js
packages/lwc-engine/dist/umd/es2017/engine.js
packages/lwc-engine/dist/modules/es2017/engine.js
packages/lwc-engine/dist/commonjs/es2017/engine.js
packages/lwc-engine/src/framework/patch.ts
packages/lwc-integration/src/shared/test-case.js
packages/lwc-template-compiler/src/__tests__/fixtures/regression/slot-name-with-dash/actual.html
lerna.json
@yungcheng yungcheng self-assigned this Jan 22, 2018
@yungcheng
Copy link
Contributor

let me include all of them in #20

@yungcheng
Copy link
Contributor

our README.md is very broken though, the project philosophy points to an internal google doc

@yungcheng
Copy link
Contributor

also for links such as // See https://git.soma.salesforce.com/raptor/raptor/issues/791 for more, I actually prefer we keep them for history lookup, any objections?

@pmdartus
Copy link
Member Author

Maybe you should add a description to remove the link to the link to internal repo.

@yungcheng
Copy link
Contributor

do we want to nuke CHANGELOG.md and start from scratch here? @diervo @caridy ?

@yungcheng
Copy link
Contributor

@pmdartus there are actually already description, issue link is for more detailed info, as a compromise, I am thinking about using See lwc (internal) #791 for more

@pmdartus
Copy link
Member Author

I am thinking about using See lwc (internal) #791 for more

People willing to contribute to open source will not be able to access the issue. I would rather add a concise description. Furthermore in the future once open-sourced, I am wondering if we would remove the internal repo completely.

@apapko
Copy link
Collaborator

apapko commented Jan 23, 2018

i will update:
docs/proposals/error-code-system-2-mimic-assembly-script.md
docs/proposals/structured-commits.md

@apapko
Copy link
Collaborator

apapko commented Jan 23, 2018

@yungcheng why do you want to delete changelog.md in this repo?
As for salesforce/lwc it has its own changelog

@yungcheng
Copy link
Contributor

@apapko i didn't delete CHANGELOG.md, but the content of it 😃

@yungcheng
Copy link
Contributor

actually after a second thought, I am going to leave CHANGELOG.md as-is and not include it in the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants