Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle our licenses correctly in our npm packages #4133

Closed
nolanlawson opened this issue Apr 10, 2024 · 0 comments · Fixed by #4134
Closed

Bundle our licenses correctly in our npm packages #4133

nolanlawson opened this issue Apr 10, 2024 · 0 comments · Fixed by #4134

Comments

@nolanlawson
Copy link
Contributor

There are two issues right now with our licenses:

  1. We don't actually ship a LICENSE file in each of our monorepo sub-packages – we just put "license": "MIT" in the package.json.
  2. In some cases we pre-bundle our own dependencies to avoid CJS/ESM compat issues. We should redistribute the correct license as necessary.

I did a check of all these bundled dependencies:

This also needs to be done carefully since some tools like https://socket.dev actually warn when a package contains multiple LICENSE files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant