Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(wire-service): support optional config object on @wire #473

Merged
merged 1 commit into from Jul 5, 2018
Merged

fix(wire-service): support optional config object on @wire #473

merged 1 commit into from Jul 5, 2018

Conversation

kevinv11n
Copy link
Contributor

Fixes #181 and #149

Details

Config bag is optional resulting in no static or params fields on the compiled wire definition.

Does this PR introduce a breaking change?

  • Yes
  • No

@salesforce-best-lwc-internal
Copy link

Benchmark results

Base commit: fcbbd0d | Target commit: b25b72a

@kevinv11n kevinv11n merged commit 34f0d85 into master Jul 5, 2018
@kevinv11n kevinv11n deleted the kv/wire-decorator-optional-config branch July 5, 2018 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trevor-bliss trevor-bliss trevor-bliss approved these changes

@rsalvador rsalvador Awaiting requested review from rsalvador

@caridy caridy Awaiting requested review from caridy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinv11n @trevor-bliss