-
Notifications
You must be signed in to change notification settings - Fork 394
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
I can still commit a wrong title (non-conventional) #55
Comments
diervo
changed the title
I can still commit a wrong
I can still commit a wrong title (non-conventional)
Feb 2, 2018
Update: this issue is observed when there is only one commit and user triggers squash and merge. In a multi-commit scenario, github will automatically pickup PR title as a merge commit message; however, it doesn't do that for a single commit. |
well, squash and merge is all we do! |
We just need to have a prehook commit in the client that enforces the conventional commit. Then everything else will work. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
When doing the final merge, if the title is incorrect, it will still go through hence not allowing the change-log to pick the changes properly.
Steps to Reproduce
Example: ccbd126
The text was updated successfully, but these errors were encountered: