Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I can still commit a wrong title (non-conventional) #55

Closed
diervo opened this issue Feb 2, 2018 · 4 comments · Fixed by #78
Closed

I can still commit a wrong title (non-conventional) #55

diervo opened this issue Feb 2, 2018 · 4 comments · Fixed by #78
Assignees

Comments

@diervo
Copy link
Contributor

diervo commented Feb 2, 2018

Description

When doing the final merge, if the title is incorrect, it will still go through hence not allowing the change-log to pick the changes properly.

Steps to Reproduce

Example: ccbd126

@diervo diervo changed the title I can still commit a wrong I can still commit a wrong title (non-conventional) Feb 2, 2018
@apapko
Copy link
Collaborator

apapko commented Feb 2, 2018

@diervo we shouldn't be able to merge if the title is invalid - I opened an issue for you a while back to make title validation failure blocking: #34, need to tweak git settings

@apapko
Copy link
Collaborator

apapko commented Feb 5, 2018

Update: this issue is observed when there is only one commit and user triggers squash and merge. In a multi-commit scenario, github will automatically pickup PR title as a merge commit message; however, it doesn't do that for a single commit.

@caridy
Copy link
Contributor

caridy commented Feb 6, 2018

well, squash and merge is all we do!

@diervo
Copy link
Contributor Author

diervo commented Feb 6, 2018

We just need to have a prehook commit in the client that enforces the conventional commit. Then everything else will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants