Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid synthetic shadow specific logic for light dom in native mode #2483

Merged
merged 2 commits into from Sep 7, 2021
Merged

fix: avoid synthetic shadow specific logic for light dom in native mode #2483

merged 2 commits into from Sep 7, 2021

Conversation

ekashida
Copy link
Member

@ekashida ekashida commented Sep 7, 2021

Details

@pmdartus feedback from #2477

Does this PR introduce breaking changes?

No

GUS work item

236 Trust

@nolanlawson
Copy link
Contributor

This is great. I like conceptually having a big if (renderer.isSyntheticShadowDefined) {} block that we know only applies to synthetic shadow. It will make it easier to remove when/if synthetic shadow itself is removed.

@ekashida ekashida changed the title fix: minimize synthetic shadow implementation details for light dom components fix: avoid synthetic shadow specific logic for light dom in native mode Sep 7, 2021
@ekashida ekashida merged commit a50b158 into master Sep 7, 2021
@ekashida ekashida deleted the ekashida/adjustments branch September 7, 2021 21:16
@pmdartus
Copy link
Member

pmdartus commented Sep 8, 2021

This is a great PR. I already see a couple of place that we might also want to wrap with if (renderer.isSyntheticShadowDefined) {} check. 😉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nolanlawson nolanlawson nolanlawson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ekashida @nolanlawson @pmdartus