test: Migrate jest to use projects feature #322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmdartus
commented
May 21, 2018
| // This method is internal to the engine and should only be used for testing purposes! | ||
| // The component registry need to get flushed between each test to avoid having the | ||
| // engine warning about multiple class registration with the same tag name. | ||
| export function flushComponentRegistry() { |
There was a problem hiding this comment.
@davidturissini Here is the newly added method that we discussed on last Friday.
There was a problem hiding this comment.
let's chat about this. We should discuss if we really need a registry for now or not. Also, if this method is supposed to stay, it should throw if it is ever invoked outside of test mode. Let's add the if condition here.
There was a problem hiding this comment.
Let's remove the registry.
|
So, we were using this feature a while back (projects) and it was very buggy. Has this become more stable? I recall there being many caching issues with this. |
|
I didn't had any issue. I would be interested if you can pull this branch and give a try at it. |
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
davidturissini
force-pushed
the
pmdartus/jest-restructure
branch
from
851eb6f
to
7e7d3ac
Compare
Benchmark resultsBase commit: lwc-engine-benchmark
|
trevor-bliss
approved these changes
May 25, 2018
scripts/jest/root.config.js
Outdated
| @@ -0,0 +1,16 @@ | |||
| const path = require('path'); | |||
davidturissini
force-pushed
the
pmdartus/jest-restructure
branch
from
7e7d3ac
to
bfe25cf
Compare
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
reviewed
May 29, 2018
| @@ -76,7 +76,7 @@ describe('error boundary component', () => { | |||
| return html; | |||
| } | |||
| } | |||
| const boundaryHostElm = createElement('x-boundary', {is: BoundryHost}); | |||
| const boundaryHostElm = createElement('x-parent', {is: BoundryHost}); | |||
There was a problem hiding this comment.
I changed it not to conflict with line 70, one of the children of x-boundary is also a x-boundary but with a different class. The engine logs a warning because of this.
caridy
reviewed
May 29, 2018
| @@ -7,27 +7,28 @@ import { VNode } from "../../3rdparty/snabbdom/types"; | |||
| import { Component } from "../component"; | |||
| import { unwrap } from "../main"; | |||
| import { querySelector } from "../dom"; | |||
| import { callbackify } from "util"; | |||
There was a problem hiding this comment.
hate when we have util package, it messes up with our regular autoimports if they match the same exported name :(
There was a problem hiding this comment.
Nice catch. I will remove this, it was inserted by VSCode!
… into pmdartus/jest-restructure
Benchmark resultsBase commit: lwc-engine-benchmark
|
caridy
reviewed
May 30, 2018
| @@ -85,7 +84,8 @@ const hook: Hooks = { | |||
| renderVM(vm); | |||
| }, | |||
| create(oldVNode: VNode, vnode: VNode) { | |||
| createVM(vnode.sel as string, vnode.elm as HTMLElement, vnode.data.slotset); | |||
| const { slotset, ctor } = vnode.data; | |||
There was a problem hiding this comment.
this branch seems to be out of sync with master.
caridy
reviewed
May 30, 2018
| const Ctor = getCtorByTagName(sel); | ||
| const { forceTagName } = Ctor as ComponentConstructor; | ||
|
|
||
| const Ctor = options.is; |
There was a problem hiding this comment.
again, this is very out of sync with master! Here is you have to untangle Ctor, and them get the forceTagName from it.
caridy
suggested changes
May 30, 2018
Benchmark resultsBase commit: lwc-engine-benchmark
|
|
Rebased with the latest master. |
caridy
reviewed
May 30, 2018
| @@ -91,25 +90,26 @@ export function createElement(sel: string, options: any = {}): HTMLElement { | |||
| if (!isObject(options) || isNull(options)) { | |||
| throw new TypeError(); | |||
| } | |||
| const { is } = (options as any); | |||
|
|
|||
| const { is: Ctor } = (options as any); | |||
There was a problem hiding this comment.
You need to do the circular check here too, otherwise you can't extract the tagName. In the old code, check that we first register it, then we extract it from the registry (which is already resolved if it is circular)
caridy
suggested changes
May 30, 2018
caridy
reviewed
May 31, 2018
| @@ -91,7 +91,9 @@ export function createElement(sel: string, options: any = {}): HTMLElement { | |||
| throw new TypeError(); | |||
| } | |||
|
|
|||
| const { is: Ctor } = (options as any); | |||
| let { is: Ctor } = (options as any); | |||
| Ctor = resolveCircularModuleDependency(Ctor); | |||
There was a problem hiding this comment.
nip: single liner: const Ctor = resolveCircularModuleDependency(options.is)
Benchmark resultsBase commit: lwc-engine-benchmark
|
Benchmark resultsBase commit: lwc-engine-benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This PR changes the way jest is configured in the mono-repo, to leverage the
projectsfeature properly. This would allow us to have a different jest config for each project.Changes:
rootinstead oftemplateIn upcoming a PR I want to get rid of all the remaining warnings by introducing a custom matcher that will trap the warnings and the errors (#94, #104). All the unexpected console
log,warnanderrorshould make the test fail. Doing this would greatly improve quality and the consistency of the warnings the engine surfaces.Does this PR introduce a breaking change?