feat(versioning): make parse5 warnings into errors #3351
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Feb 17, 2023
| @@ -27,5 +27,4 @@ | |||
| <template if:true={doRender}> | |||
| <tr></tr> | |||
| </template> | |||
| </template> | |||
There was a problem hiding this comment.
As it turns out, we accidentally made this mistake, and I discovered it in our Karma tests. 😆
This was referenced Feb 17, 2023
nolanlawson
added
feature/api-versioning
nolanlawson
force-pushed
the
nolan/api-version-2
branch
from
068688e
to
375f23e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This is a 4-part PR.
Part 1: basic scaffolding for versioning (#3350)
Part 2: using it in the template compiler (this PR)
Part 3: using it in the runtime (#3352)
Part 4: using it in the Babel plugin (#3354)
I decided to fix #3258 as an example of using API versioning in the compiler. Here, the template compiler is looking for v59 and in that case, turning warnings into errors.
Fixes #3258
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-12566318