feat: add LWS flag & import babel plugins #3357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
a-chabot
force-pushed
the
a-chabot/lws-flag-babel
branch
from
921899f
to
076fe6f
Compare
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
jdalton
reviewed
Feb 21, 2023
| if (lws) { | ||
| plugins.push( | ||
| '@locker/babel-plugin-transform-unforgeables', | ||
| '@babel/plugin-transform-async-to-generator', |
There was a problem hiding this comment.
☝️ For async-await support
jdalton
reviewed
Feb 21, 2023
| plugins.push( | ||
| '@locker/babel-plugin-transform-unforgeables', | ||
| '@babel/plugin-transform-async-to-generator', | ||
| '@babel/plugin-proposal-async-generator-functions' |
There was a problem hiding this comment.
☝️ For for await...of support
(despite the plugin name of "proposal" this feature is stage 4 and no longer a proposal)
nolanlawson
reviewed
Feb 21, 2023
nolanlawson
reviewed
Feb 21, 2023
nolanlawson
requested changes
Feb 21, 2023
There was a problem hiding this comment.
Can you add a sniff test to confirm that the lws option works? Otherwise LGTM
Closed
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
a-chabot
commented
Feb 22, 2023
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
jdalton
reviewed
Feb 22, 2023
packages/@lwc/compiler/src/transformers/__tests__/transform-javascript.spec.ts
Outdated
Show resolved
Hide resolved
packages/@lwc/compiler/src/transformers/__tests__/transform-javascript.spec.ts
Outdated
Show resolved
Hide resolved
a-chabot
commented
Feb 22, 2023
packages/@lwc/compiler/src/transformers/__tests__/transform-javascript.spec.ts
Outdated
Show resolved
Hide resolved
nolanlawson
requested changes
Feb 22, 2023
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
jdalton
reviewed
Feb 22, 2023
packages/@lwc/compiler/src/transformers/__tests__/transform-javascript.spec.ts
Outdated
Show resolved
Hide resolved
jdalton
reviewed
Feb 22, 2023
packages/@lwc/compiler/src/transformers/__tests__/transform-javascript.spec.ts
Show resolved
Hide resolved
jdalton
reviewed
Feb 23, 2023
packages/@lwc/compiler/src/transformers/__tests__/transform-javascript.spec.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
jdalton
reviewed
Feb 23, 2023
packages/@lwc/compiler/src/transformers/__tests__/transform-javascript.spec.ts
Outdated
Show resolved
Hide resolved
jdalton
reviewed
Feb 23, 2023
packages/@lwc/compiler/src/transformers/__tests__/transform-javascript.spec.ts
Outdated
Show resolved
Hide resolved
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
ravijayaramappa
requested changes
May 18, 2023
nolanlawson
reviewed
May 26, 2023
packages/@lwc/compiler/src/transformers/__tests__/transform-javascript.spec.ts
Show resolved
Hide resolved
nolanlawson
reviewed
May 26, 2023
nolanlawson
approved these changes
May 26, 2023
There was a problem hiding this comment.
This LGTM after a few nitpicks, but I'd also like a +1 from @ravijayaramappa
ravijayaramappa
approved these changes
May 30, 2023
Signed-off-by: Alex Chabot <a.chabot@salesforce.com>
a-chabot
force-pushed
the
a-chabot/lws-flag-babel
branch
from
8c87968
to
c7f7df7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
feat: add LWS flag & import babel plugins
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
@W-12560396 -- Enable LWS babel transform integration in OSS LWC compiler