fix(hydration): log errors/warnings only in dev mode #3534
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Wraps all error/warn logs in
hydration.ts
in aprocess.env.NODE_ENV !== 'production'
check. Prompted by #2939 (comment)Note we don't really have a test for this yet, because we only run the hydration tests in dev mode (#3253).
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?