chore: update more babel deps #3576
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Jun 15, 2023
| import MatcherUtils = jest.MatcherUtils; | ||
| import CustomMatcherResult = jest.CustomMatcherResult; | ||
| const { globSync } = glob; |
There was a problem hiding this comment.
Jest errors for some reason now unless we do import * as
nolanlawson
commented
Jun 15, 2023
| @@ -38,7 +38,6 @@ | |||
| "@rollup/plugin-replace": "^5.0.2", | |||
| "@rollup/plugin-typescript": "^11.1.1", | |||
| "@types/babel__core": "^7.20.1", | |||
| "@types/glob": "^8.1.0", | |||
There was a problem hiding this comment.
No longer needed since glob ships with its own types, and these types were messing us up.
nolanlawson
commented
Jun 15, 2023
| "devDependencies": { | ||
| "@babel/core": "^7.22.5", | ||
| "@babel/helper-explode-assignable-expression": "^7.18.6", |
There was a problem hiding this comment.
Not sure why this happened, but compat mode isn't long for this world, so we'll remove this soon anyway
|
/nucleus test |
ravijayaramappa
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Updates our remaining Babel deps. Follow-up to #3573
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?