fix: drop support for Edge 18 and Safari 13 #3648
Conversation
|
/nucleus test |
| @@ -46,7 +46,7 @@ commands: | |||
| coverage: | |||
| type: boolean | |||
| default: false | |||
| compat: | |||
There was a problem hiding this comment.
I decided the word compat was too overloaded at this point, so I renamed this to legacy_browsers.
| @@ -15,7 +15,6 @@ type E = HostElement; | |||
| export type LifecycleCallback = (elm: E) => void; | |||
|
|
|||
| export interface RendererAPI { | |||
| isNativeShadowDefined: boolean; | |||
There was a problem hiding this comment.
Now that we are dropping Edge 18, all of our tested browsers support shadow DOM.
| @@ -5,7 +5,6 @@ | |||
| "scripts": { | |||
| "start": "karma start ./scripts/karma-configs/test/local.js", | |||
| "test": "karma start ./scripts/karma-configs/test/local.js --single-run --browsers ChromeHeadless", | |||
| "test:compat": "COMPAT=1 yarn test", | |||
There was a problem hiding this comment.
This was unused anyway.
| COMPAT, | ||
| DISABLE_SYNTHETIC: !SYNTHETIC_SHADOW_ENABLED, | ||
| }, | ||
| }, |
There was a problem hiding this comment.
I dunno what this was doing. According to SauceLabs, it is "User-defined custom data that will accept any valid JSON object, limited to 64KB in size." I assume it just goes in the Circle CI UI somewhere.
| @@ -44,7 +43,6 @@ function createEnvFile() { | |||
| window.process = { | |||
| env: { | |||
| NODE_ENV: ${JSON.stringify(NODE_ENV_FOR_TEST || 'development')}, | |||
| COMPAT: ${COMPAT}, | |||
There was a problem hiding this comment.
Our tests no longer need to know if they are running in a compat browser!
There was a problem hiding this comment.
Don't be fooled – this file is just renamed from create-custom-element-using-upgradable-constructor and GitHub doesn't realize it.
There was a problem hiding this comment.
Turns out I forgot to remove this unused file a while back, in #3310
There was a problem hiding this comment.
You're probably gonna want to use Hide whitespace in the GitHub UI for all these test files.
| } | ||
|
|
||
| export const isNativeShadowRootDefined = !isNull(NativeShadowRoot); | ||
| const NativeShadowRoot = ShadowRoot; |
There was a problem hiding this comment.
nit: do we still need NativeShadowRoot or can that be removed and just have isInstanceOfNativeShadowRoot reference ShadowRoot directly? It's only referenced twice in this file and not exported.
There was a problem hiding this comment.
I think we still need to capture the globalThis.ShadowRoot once, since synthetic shadow will override it. But I can definitely clean up this logic: 766bfab
| } | ||
| export { assignedNodes, assignedElements }; | ||
| export const assignedNodes = HTMLSlotElement.prototype.assignedNodes; | ||
| export const assignedElements = HTMLSlotElement.prototype.assignedElements; |
There was a problem hiding this comment.
I wonder how many of these types of assignments could be refactored away in the synthetic-shadow package now that more and more of them are just extra layers of assignments with no added wrapper functionality. (e.g. window.ts).
There was a problem hiding this comment.
I'm sure a lot of it could, yeah. I held back from heavy refactoring, though, since synthetic shadow is deprecated, and minifiers will clean up a lot of these abstraction layers anyway.
|
/nucleus test |
Details
Drops support for Edge 18 and Safari 13. Removes (almost) all the last vestiges of compat mode from the codebase.
Context on browser support
Does this pull request introduce a breaking change?
Technically this is not a breaking change, because we already dropped official support for these browsers in LWC v3.0.0.
Does this pull request introduce an observable change?
GUS work item
W-13818697