Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move parse5 to devDeps #3786

Merged
merged 1 commit into from
Oct 10, 2023
Merged

fix: move parse5 to devDeps #3786

merged 1 commit into from
Oct 10, 2023

Conversation

jye-sf
Copy link
Contributor

@jye-sf jye-sf commented Oct 10, 2023

Details

As part of the upgrade to v7, the parse5 dependency should be moved to devDependencies so that it is properly inlined into the dist/ bundles.

nodeResolve({
// These are the devDeps that may be inlined into the dist/ bundles
// These include packages owned by us (LWC, observable-membrane), as well as parse5
// and its single dependency, which are bundled because it makes it simpler to distribute
resolveOnly: [/^@lwc\//, 'observable-membrane', /^parse5($|\/)/, 'entities'],
}),

Does this pull request introduce a breaking change?

  • ✅ No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • ✅ No, it does not introduce an observable change.

GUS work item

@jye-sf jye-sf requested a review from a team as a code owner October 10, 2023 16:35
@jye-sf
Copy link
Contributor Author

jye-sf commented Oct 10, 2023

@nolanlawson For the dist/ files,
index.cjs.js: 211KB -> 559KB
index.cjs.js.map: 184KB -> 848KB

@nolanlawson
Copy link
Contributor

Thanks! This is similar to the sizes for engine-server, so nothing to be alarmed about.

@nolanlawson nolanlawson merged commit bf8565f into master Oct 10, 2023
11 checks passed
@nolanlawson nolanlawson deleted the jye/parse5-devdep branch October 10, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants