test: fix aria tests in Firefox Nightly #3792
Conversation
| // Our polyfill or the current spec – setting undefined is not treated like null | ||
| // Our polyfill - null removes | ||
| falsyValuesThatRemove.push(null); | ||
| // Our polyfill – setting undefined is not treated like null | ||
| falsyValuesThatDoNotRemove.push(undefined); | ||
| } |
There was a problem hiding this comment.
A lot of these tests are kind of dumb – testing a thing, and then asserting that your test does the same thing it just did. Maybe once the browsers are all in alignment, we can vastly simplify this test.
There was a problem hiding this comment.
Verified with Firefox Nightly 120.0a1 and tests are passing!
Side note, do you think we should add safari + firefox karma launchers to the integration-karma repos? (Doesn't look like they've been updated in a while though)
I'm thinking about having the dev dependencies installed but not configured to run by default for local setups, might help reduce setting it up for local testing.
|
I don't personally think it's worth it – it's an extra dependency, and right now I find that |
Details
Firefox 119 (scheduled to be released on October 24th) will potentially contain a bug that will break a bunch of our ARIA reflection tests. Rather than wait to be broken, let's proactively make these tests resilient to Firefox 119.
Note that I didn't bother to add Firefox Nightly to our test matrix, because I don't think it's worth it to run in CI every time. So you'll have to believe me that these new tests pass. 🙃
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?