fix(template-compiler): fix static listeners with deep paths #3807
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Oct 16, 2023
|
|
||
| // Cloning here is necessary because `this.replace()` is destructive, and we might use the | ||
| // node later during static content optimization | ||
| expression = doStructuredClone(expression); |
There was a problem hiding this comment.
This is a really subtle bug – the code below is mutating the AST, which only becomes a problem later if we try to re-use it, which we do during the static content optimization, which is a second pass on top of the first pass we already did.
First pass:
Second pass:
nolanlawson
commented
Oct 16, 2023
| const doStructuredClone = | ||
| typeof structuredClone === 'function' | ||
| ? structuredClone | ||
| : (obj: any) => JSON.parse(JSON.stringify(obj)); |
There was a problem hiding this comment.
I manually ran the Karma tests in Node 16 just to be safe.
|
Looks like the AST format changed... will need another look. |
|
Found a pre-existing issue: #3808 |
ekashida
reviewed
Oct 16, 2023
packages/@lwc/integration-karma/test/static-content/x/deepListener/deepListener.html
Outdated
Show resolved
Hide resolved
packages/@lwc/integration-karma/test/static-content/x/deepListener/deepListener.js
Outdated
Show resolved
Hide resolved
packages/@lwc/integration-karma/test/static-content/x/deepListener/deepListener.js
Outdated
Show resolved
Hide resolved
packages/@lwc/integration-karma/test/static-content/x/deepListener/deepListener.js
Outdated
Show resolved
Hide resolved
…ener/deepListener.html Co-authored-by: Eugene Kashida <ekashida@gmail.com>
…ener/deepListener.js Co-authored-by: Eugene Kashida <ekashida@gmail.com>
…ener/deepListener.js Co-authored-by: Eugene Kashida <ekashida@gmail.com>
…ener/deepListener.js Co-authored-by: Eugene Kashida <ekashida@gmail.com>
nolanlawson
commented
Oct 17, 2023
packages/@lwc/integration-karma/test/static-content/x/deepListener/deepListener.html
Outdated
Show resolved
Hide resolved
nolanlawson
commented
Oct 17, 2023
packages/@lwc/integration-karma/test/static-content/x/deepListener/deepListener.html
Outdated
Show resolved
Hide resolved
…ener/deepListener.html
…ener/deepListener.html
ekashida
approved these changes
Oct 17, 2023
louis-murray
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #3804
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?