chore(integration-karma): fix sourcemaps #3875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Nov 17, 2023
| const { rollup } = require('rollup'); | ||
| const replace = require('@rollup/plugin-replace'); | ||
| const MagicString = require('magic-string'); | ||
| const { init, parse } = require('es-module-lexer'); |
There was a problem hiding this comment.
I switched from using Rollup to using magic-string and es-module-lexer to transform ESM into IIFE.
This new method should be a lot faster, since we really don't need all of Rollup just to transform our framework files (e.g. engine-dom/dist/index.js). These files don't have any imports, and just need some light editing to replace some strings and convert ESM to IIFE.
nolanlawson
commented
Nov 18, 2023
| uses: actions/upload-artifact@v3 | ||
| with: | ||
| name: coverage-report-combined | ||
| path: ./packages/@lwc/integration-karma/coverage/combined |
There was a problem hiding this comment.
We might as well upload the combined coverage files, especially now that the HTML actually works.
|
Added the summary data to the GitHub step action results:
|
ekashida
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
This fixes sourcemaps in the Karma tests. I confirmed that you can actually set breakpoints in
engine-domusingkarma start, and that the Istanbul coverage HTML reports actually work now:Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?