Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: log shadow mode through engine reporting API #3884

Merged
merged 4 commits into from
Dec 5, 2023

Conversation

jye-sf
Copy link
Contributor

@jye-sf jye-sf commented Nov 28, 2023

Details

Adds telemetry for shadow mode usage (synthetic vs native). Due to the volume of logs this is going to generate (easily TBs), we'll want to report this as a metric rather than as logs. We will do this in the consuming app container. (e.g. if (reportName === 'ShadowModeUsage') { ... }).

Does this pull request introduce a breaking change?

  • ✅ No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • ✅ No, it does not introduce an observable change.

GUS work item

@jye-sf jye-sf requested a review from a team as a code owner November 28, 2023 23:53
@nolanlawson
Copy link
Contributor

This is just a backport of #3878 right?

@jye-sf
Copy link
Contributor Author

jye-sf commented Dec 4, 2023

This is just a backport of #3878 right?

Yes, that's correct.

@jye-sf
Copy link
Contributor Author

jye-sf commented Dec 4, 2023

Updated with changes made to #3878

Copy link
Contributor

❌ One or More Pre-release Checks Failed

  • Check PR user has rights to execute the workflow
    PR owner is allowed to initiate release/deploy

  • Check PR is approved
    PR 3884 is approved

  • Check PR is mergeable
    PR 3884 is mergeable

  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR

  • Check no conflicting Github release
    A Github release already exists with a tag of v5.0.2. Please commit/push a version bump to the jye/report-shadow-mode-spring24 branch or have Nucleus do it for you by responding with the following comment
    /nucleus bump-version [version]

    To skip this check, run /nucleus release --force

  • Check NPM packages have not been released yet
    Version 5.0.2 of this project has already been published. If you would like to skip NPM publishing, then run /nucleus release --skipNpmRelease.If you want to bump the version in your source branch, run /nucleus bump-version [version]

  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts

  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

@jye-sf jye-sf merged commit 3fa8c19 into spring24 Dec 5, 2023
9 of 10 checks passed
@jye-sf jye-sf deleted the jye/report-shadow-mode-spring24 branch December 5, 2023 07:15
Copy link
Contributor

❌ One or More Pre-release Checks Failed

  • ⚪️ Check PR user has rights to execute the workflow (skipped)
    Skipping PR owner check since PR has already been merged.

  • Check PR is approved
    PR 3884 is approved

  • ⚪️ Check PR is mergeable (skipped)
    PR 3884 has already been merged

  • ⚠️ Check GUS reference is present
    PR does not contain a reference to a GUS work item. You can update it any time by including '@W-XXXXXXX' into the title or body of the PR

  • Check no conflicting Github release
    A Github release already exists with a tag of v5.0.2. Please commit/push a version bump to the jye/report-shadow-mode-spring24 branch or have Nucleus do it for you by responding with the following comment
    /nucleus bump-version [version]

    To skip this check, run /nucleus release --force

  • Check NPM packages have not been released yet
    Version 5.0.2 of this project has already been published. If you would like to skip NPM publishing, then run /nucleus release --skipNpmRelease.If you want to bump the version in your source branch, run /nucleus bump-version [version]

  • ⚪️ Check Maven artifacts have not been released yet (skipped)
    Skipping check since project doesn't deliver Maven artifacts

  • ⚪️ Check GAV mapping exists for jar repo (skipped)
    Skipping GAV mapping check because a core jar is not being released.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants