fix(engine-dom): use native lifecycle callbacks #3904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsjtu
reviewed
Dec 19, 2023
Comment on lines
+46
to
+49
| // When in native lifecycle mode, we need to keep track of instances that were created outside LWC | ||
| // (i.e. not created by `lwc.createElement()`). If the element uses synthetic lifecycle, then we don't | ||
| // need to track this. | ||
| nativeLifecycleElementsToUpgradedByLWC.set(this, elementBeingUpgradedByLWC); |
There was a problem hiding this comment.
Yeah I was pleased that I was able to do this with just one Map!
Co-authored-by: James Tu <jmsjtu@gmail.com>
jmsjtu
approved these changes
Dec 19, 2023
…cle-for-real-this-time
…this-time' into nolan/native-lifecycle-for-real-this-time
…lifecycle-for-real-this-time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
BREAKING CHANGE: Use native custom element lifecycle for API version >=61.
Fixes #3198. New version of #3662. The umpteenth attempt to land this thing.
Does this pull request introduce a breaking change?
All details are catalogued in #3662. The only difference this time is that this is for API version 61 rather than 60.
Does this pull request introduce an observable change?
See above.