Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(lwc-engine): update README example #3922

Merged
merged 2 commits into from
Jan 2, 2024

Conversation

JaydeepGo
Copy link
Contributor

Details

After the change #3594 changes, We can't import renderComponent from LWC. So updating the Doc to reflect the same.

Does this pull request introduce a breaking change?

  • ✅ No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • ✅ No, it does not introduce an observable change.

GUS work item

NA

@JaydeepGo JaydeepGo requested a review from a team as a code owner December 24, 2023 20:09
Copy link

Thanks for the contribution! Before we can merge this, we need @JaydeepGo to sign the Salesforce Inc. Contributor License Agreement.

@nolanlawson
Copy link
Contributor

Thanks! You're right; looks like this was a breaking change.

@nolanlawson
Copy link
Contributor

@JaydeepGo I know it's a bit silly, but we can't merge this if you don't sign the CLA. Would you mind signing?

@JaydeepGo
Copy link
Contributor Author

Hi @nolanlawson
I have been in the open source system and It's a totally reasonable ask. I have already signed the CLA on 24 Dec. Is there anything else I need to do here to trigger the CLA validation again?
image

@nolanlawson nolanlawson mentioned this pull request Jan 2, 2024
@nolanlawson nolanlawson merged commit 7af0faa into salesforce:master Jan 2, 2024
11 of 14 checks passed
@JaydeepGo
Copy link
Contributor Author

Hi @nolanlawson Thanks for merging the PR.

For a hobby project, I planned to use the LWC SSR cmp with the Eleventy. In this process, I have found that the current https://lwc.dev/ documentation is not up to date with the new Node ES6 syntax and some parts like LWC SSR example don’t properly work #lwc-framework query link.
Do we have any repository where I can update the documentation? If not, where can I raise the request to update the doc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants