New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add reporting for shadowSupportMode #3980
Conversation
ctorShadowSupportMode === ShadowSupportMode.Native) | ||
) { | ||
report(ReportingEventId.ShadowSupportModeUsage, { | ||
tagName: ctorName, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using tagName here to avoid having to make changes to our o11y schema in 248/patch. This should use its own field 'ctorName' or 'name' rather than 'tagName'.
if ( | ||
isReportingEnabled() && | ||
(ctorShadowSupportMode === ShadowSupportMode.Any || | ||
ctorShadowSupportMode === ShadowSupportMode.Native) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right now we only care about 'Any' and 'Native'.
* feat: add reporting for shadowSupportMode
Details
Adds logging for shadowSupportMode 'any' and 'native'.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item