fix: event listener not being invoked for native web components #4012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
approved these changes
Feb 22, 2024
There was a problem hiding this comment.
This looks reasonable to me, and I imagine the risk of breakage is low since it only affects native-within-synthetic.
One thing that may be useful is to add a test for a native shadow LWC component inside of the parent synthetic shadow container. AIUI, this doesn't have anything to do with lwc:external or third-party custom elements – it just has to do with native-shadow-inside-synthetic-shadow.
packages/@lwc/integration-karma/test/mixed-shadow-mode/contextualComposedPath/index.spec.js
Outdated
Show resolved
Hide resolved
...ages/@lwc/integration-karma/test/mixed-shadow-mode/contextualComposedPath/x/parent/parent.js
Outdated
Show resolved
Hide resolved
ekashida
reviewed
Feb 22, 2024
packages/@lwc/synthetic-shadow/src/polyfills/event-target/polyfill.ts
Outdated
Show resolved
Hide resolved
packages/@lwc/integration-karma/test/mixed-shadow-mode/contextualComposedPath/index.spec.js
Outdated
Show resolved
Hide resolved
packages/@lwc/integration-karma/test/mixed-shadow-mode/contextualComposedPath/index.spec.js
Outdated
Show resolved
Hide resolved
packages/@lwc/integration-karma/test/mixed-shadow-mode/contextualComposedPath/index.spec.js
Outdated
Show resolved
Hide resolved
...ages/@lwc/integration-karma/test/mixed-shadow-mode/contextualComposedPath/x/parent/parent.js
Outdated
Show resolved
Hide resolved
ekashida
force-pushed
the
composed-path-shadow-polyfill
branch
from
4dd18b2
to
fe0abfc
Compare
ekashida
added a commit
that referenced
this pull request
Mar 19, 2024
* fix: event listener not being invoked for native web components * chore: simplify test * chore: test tweaks * chore: also avoid wrapping listeners for non-Node EventTargets * chore: account for light dom nodes * chore: account for window --------- Co-authored-by: Eugene Kashida <ekashida@gmail.com>
ekashida
added a commit
that referenced
this pull request
Mar 19, 2024
… (#4080) Co-authored-by: Jason Ye <40873183+jye-sf@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Addresses #4011.
This PR attempts to bypass our
addEventListener()patch when working with event targets under a native shadow root.Remaining work:
removeEventListener()to avoid inconsistent behavior?Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
This changes the composed path in some scenarios. The full, explicit list of scenarios may need to be explored.
GUS work item