Revert "fix(synthetic-shadow): retargeting does not correctly account for native shadow roots" #4047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… for nat…" This reverts commit 13cd45f.
jmsjtu
approved these changes
Mar 12, 2024
ravijayaramappa
added a commit
that referenced
this pull request
Mar 12, 2024
* refactor: organize API versioning tests (#4040) * fix: disable form association entirely on older API versions (#4041) Fixes #3929 * Revert "fix(synthetic-shadow): retargeting does not correctly account for nat…" (#4047) This reverts commit 13cd45f. * chore: routine dependencies update (#4046) * chore: routine dependencies update * fix: revert prettier updates * chore: update husky * chore: update husky * fix: disable ts rule * chore: v6.3.2 (#4048) --------- Co-authored-by: Nolan Lawson <nlawson@salesforce.com> Co-authored-by: Eugene Kashida <ekashida@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4018
Our event propagation polyfill does not account for DOM mutations and can only imitate the correct native behavior if the event target is connected. In cases where the actual target becomes disconnected during propagation, the retargeting logic incorrectly returns
nullbecause we can no longer compute the composed path correctly.We should preserve the existing behavior which is to always provide access to the actual target if it is disconnected. This means that we should also check that the root node of the disconnected target is not a native shadow root, in addition to the original check for synthetic shadow root.