Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(template-compiler): add complex template expression binding support for computed properties #4065

Merged
merged 3 commits into from Mar 15, 2024

Conversation

ekashida
Copy link
Member

Details

arr[baz] and arr.baz are both considered member expressions, with the difference being whether the property is computed or not.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

GUS work item

W-14631155

@ekashida ekashida requested a review from a team as a code owner March 15, 2024 02:42
Copy link
Contributor

@divmain divmain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, also!

@ekashida ekashida merged commit 7d01a38 into master Mar 15, 2024
9 checks passed
@ekashida ekashida deleted the ekashida/fix-scoped-identifiers branch March 15, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants