fix: add signals as dependency #4106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rui-rayqiu
approved these changes
Mar 27, 2024
ekashida
approved these changes
Mar 27, 2024
|
Removing the Signal export from There is additional work in 252 on signals and we will export it at that time. |
jmsjtu
commented
Mar 27, 2024
| import { logWarnOnce } from '../../shared/logger'; | ||
| import type { Signal } from '@lwc/signals'; |
There was a problem hiding this comment.
This type needs to be re-exported in SignalTracker as part of the function definition types.
nolanlawson
approved these changes
Mar 27, 2024
|
Looks like some downstream are failing for a separate typescript issue, see #4107 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Not sure why this hasn't broken sooner but the
@lwc/signalspackage is causing breakages in our nucleus down streams.The reason is because the the
SignalTrackerimports theSignaltype from@lwc/signalsand because it hasn't been added as a dependency it causes breakages.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-15276750