chore: prettier everything! #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Prettier is configured for the entire repo, but the package scripts and prettier ignores are scoped only to the
packagesandscriptsdirectories. That's a nuisance when editing files outside those directories (for example, inplayground), because my IDE applies formatting and I'm left with more changes than I actually changed.This PR adjusts our prettier configuration so that everything* gets formatted, so that my diffs are actually just my diffs.
* Excluding HTML because we have cases where we intentionally test not-pretty markup.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item