Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: configure dependabot @W-15450855 #4130

Merged
merged 1 commit into from Apr 11, 2024
Merged

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Apr 10, 2024

Run once per week, grouping non-major version changes into a single PR, as they are theoretically non-breaking changes.

Details

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

GUS work item

W-15450855

Run once per week, grouping non-major version changes into a single PR, as they are theoretically non-breaking changes.
@wjhsf wjhsf requested a review from a team as a code owner April 10, 2024 20:33
theoretically-non-breaking:
update-types:
- "minor"
- "patch"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately there are some "theoretically non-breaking" updates that we currently can't take, namely acorn and tachometer:

"//": "Acorn is pinned due to a breaking change in its types in 8.11: https://github.com/acornjs/acorn/issues/1260",

"Also note we are pinned to Tachometer 0.5.10 due to a breaking change in 0.6.0.",

(Tachometer may not qualify, because I'm not sure whether Dependabot understands that 0.x.x dependencies are anything-goes when it comes to SemVer.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK well we can fix acorn separately: #4132

Copy link
Contributor

@nolanlawson nolanlawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a great start. We can fix acorn in a separate PR and then for tachometer let's just hope GitHub understands this:

Major version zero (0.y.z) is for initial development. Anything MAY change at any time. The public API SHOULD NOT be considered stable.

@wjhsf wjhsf merged commit e0e7ca4 into master Apr 11, 2024
9 checks passed
@wjhsf wjhsf deleted the wjh/configure-dependabot branch April 11, 2024 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants