chore(scripts): separate license generation from build script #4191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divmain
approved these changes
May 1, 2024
ekashida
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
lwc/package.json
Line 15 in cab5e41
The current root build script uses
nxto runbuildin all the packages, and then generates license files. This prevents me from runningyarn build -p <project>, which is lame. Also, we don't need to regenerate licenses every time we make code changes, only when we update our dependencies!This PR removes the license generation from the build script and enforces it via lint-staged and CI.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item