chore(nucleus): refresh required downstreams #4203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
May 8, 2024
| milestone-.*: # used for prerelease testing | ||
| pull-request: | ||
| <<: *branch-definition | ||
| workflow: build-and-test # the default workflow is release, and we just want build+tests |
There was a problem hiding this comment.
This was something I was messing around with at some point but stopped doing.
nolanlawson
commented
May 8, 2024
| @@ -8,21 +8,28 @@ branches: | |||
| auto-start: true | |||
| auto-start-from-forks: false | |||
| merge-method: disabled # do not auto-merge; we'll do it ourselves | |||
| validate-optional-downstream-deps: true # temporarily test non-required downstreams | |||
There was a problem hiding this comment.
This increases our overall execution cost with low value, unless we're actively doing this kind of flakiness analysis. We can turn this back on next time we want to refresh this list.
ekashida
approved these changes
May 8, 2024
|
One is due to container tests, the other to e2e tests. |
|
/nucleus ignore --reason 'flaky downstreams are flaky' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Refreshes our required Nucleus downstreams based on
Spreadsheet with analysis based on last 10 runs
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?