-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: version mismatch warning on patch version difference #4216
refactor: version mismatch warning on patch version difference #4216
Conversation
packages/@lwc/engine-core/src/framework/check-version-mismatch.ts
Outdated
Show resolved
Hide resolved
Hi @wjhsf , |
Looks like there's issues with the CLA bot - please connect your GitHub account to your Salesforce email so that CLA check is no longer necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once CI is green. It would also be great if you could please add a test here.
d4f27b0
to
553df64
Compare
Thanks for the contribution! It looks like @SourabhMulay is an internal user so signing the CLA is not required. However, we need to confirm this. |
Hi @SourabhMulay could you please sign the CLA as mentioned above? Thanks! 🙇 |
Already signed, maybe there is an issue with the cla bot. But i'll try to change the commit email once. |
553df64
to
139de64
Compare
/nucleus test |
…match-warning-for-patch-version
…match-warning-for-patch-version
/nucleus test |
/nucleus ignore --reason 'flapper unrelated to this PR' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
|
Details
Version mismatch warning should warn on patch version differences so if LWC compiler version differs from the engine version, it warns.
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?