Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: version mismatch warning on patch version difference #4216

Conversation

SourabhMulay
Copy link
Contributor

Details

Version mismatch warning should warn on patch version differences so if LWC compiler version differs from the engine version, it warns.

Does this pull request introduce a breaking change?

  • 😮‍💨 No, it does not introduce a breaking change.

Does this pull request introduce an observable change?

  • 🤞 No, it does not introduce an observable change.

@SourabhMulay SourabhMulay requested a review from wjhsf May 21, 2024 19:19
@SourabhMulay
Copy link
Contributor Author

Hi @wjhsf ,
I have done with the requested changes that you have suggested, Can you please review once.

@wjhsf
Copy link
Contributor

wjhsf commented May 30, 2024

Looks like there's issues with the CLA bot - please connect your GitHub account to your Salesforce email so that CLA check is no longer necessary.

Copy link
Contributor

@nolanlawson nolanlawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once CI is green. It would also be great if you could please add a test here.

@SourabhMulay SourabhMulay force-pushed the Saurabh/version-mismatch-warning-for-patch-version branch from d4f27b0 to 553df64 Compare June 11, 2024 18:05
Copy link

Thanks for the contribution! It looks like @SourabhMulay is an internal user so signing the CLA is not required. However, we need to confirm this.

@nolanlawson
Copy link
Contributor

Hi @SourabhMulay could you please sign the CLA as mentioned above? Thanks! 🙇

@SourabhMulay
Copy link
Contributor Author

Hi @SourabhMulay could you please sign the CLA as mentioned above? Thanks! 🙇

Already signed, maybe there is an issue with the cla bot. But i'll try to change the commit email once.

@nolanlawson
Copy link
Contributor

/nucleus test

@nolanlawson
Copy link
Contributor

/nucleus test

@nolanlawson
Copy link
Contributor

/nucleus ignore --reason 'flapper unrelated to this PR'

Copy link
Contributor

@nolanlawson nolanlawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nolanlawson nolanlawson merged commit 228a4a7 into salesforce:master Jun 14, 2024
13 of 16 checks passed
@SourabhMulay
Copy link
Contributor Author

SourabhMulay commented Jun 15, 2024

Thank you!
Thank you!! @nolanlawson.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants