fix: add selector type to all vnodes #4234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmsjtu
commented
May 29, 2024
| // Empty fragment | ||
| expect(ul.children.length).toBe(0); | ||
|
|
||
| const spy = spyConsole(); |
There was a problem hiding this comment.
I'm importing the spy directly because the error is logged by the engine and can't be caught directly when elm.items = [{ value: 1 }].
ekashida
reviewed
May 29, 2024
nolanlawson
reviewed
May 29, 2024
packages/@lwc/integration-karma/test/regression/invalid-key/index.spec.js
Outdated
Show resolved
Hide resolved
|
@jmsjtu Might as well add |
|
Agree with Nolan's comment, ScopeSlotFragment can get a sel too. |
ekashida
changed the title
jmsjtu
added a commit
that referenced
this pull request
May 29, 2024
jmsjtu
added a commit
that referenced
this pull request
May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
By expanding static content optimization to more nodes we've revealed a bug with the existing diffing algo.
In special circumstances when a text vnode is compared against a static vnode they will be considered the same vnode because we use the
selandkeyto determine vnode equality.Since both text and static vnodes have an
undefinedkeyandselvalues they are incorrectly evaluated.This PR updates the values of
selto distinguish these vnodes and prevent future false positives.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item