fix(rollup-plugin): allow any implicit HTML import from any kind of script file @W-15941938 #4261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekashida
reviewed
Jun 5, 2024
nolanlawson
approved these changes
Jun 7, 2024
| }); | ||
| const { code } = result.output[0]; | ||
|
|
||
| expect(code).toContain('all your base'); |
nolanlawson
reviewed
Jun 7, 2024
| @@ -65,13 +65,14 @@ const IMPLICIT_DEFAULT_HTML_PATH = '@lwc/resources/empty_html.js'; | |||
| const EMPTY_IMPLICIT_HTML_CONTENT = 'export default void 0'; | |||
| const IMPLICIT_DEFAULT_CSS_PATH = '@lwc/resources/empty_css.css'; | |||
| const EMPTY_IMPLICIT_CSS_CONTENT = ''; | |||
| const SCRIPT_FILE_EXTENSIONS = ['.js', '.mjs', '.jsx', '.ts', '.mts', '.tsx']; | |||
There was a problem hiding this comment.
Set / has may be faster, but maybe not since this is a tiny list anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To detect whether a component is using an implicit HTML import, we check that it's a
.jsfile. But that's not the only kind of script file that can be used! This PR adds support for all flavors of JS/TS/JSX that we might expect to encounter.Fixes #4233.
Details
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-15941938