fix: @W-13107837 add missing 'webkit' property for WKWebView #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arcadeteddy
reviewed
Apr 26, 2023
| // object from `Object.keys()` and `Reflect.ownKeys()` results, so add it. | ||
| // istanbul ignore if: currently unreachable via tests | ||
| if (ObjectHasOwn(source, 'webkit') && !ReflectApply(ArrayProtoIncludes, ownKeys, ['webkit'])) { | ||
| ownKeys[ownKeys.length] = 'webkit'; |
There was a problem hiding this comment.
If order doesn't matter, could just use ownKeys.push('webkit')
There was a problem hiding this comment.
ownKeys[ownKeys.length] = 'webkit' is equiv to push without the prototypal access.
arcadeteddy
approved these changes
Apr 26, 2023
rwaldron
approved these changes
Apr 26, 2023
|
@jdalton Is there a unit test for this? I know it would require a real iOS browser, I looked in locker repo but I didn't find one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: @W-13107837 add missing 'webkit' property for WKWebView